Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(MODULES-6627) Removes unused --host flag from mysqlcaller #1064

Merged
merged 1 commit into from
Apr 23, 2018

Conversation

HelenCampbell
Copy link
Contributor

No description provided.

@HelenCampbell HelenCampbell changed the title Removes unused --host flag from mysqlcaller MODULES-6627 Removes unused --host flag from mysqlcaller Apr 23, 2018
@HelenCampbell HelenCampbell changed the title MODULES-6627 Removes unused --host flag from mysqlcaller [MODULES-6627] Removes unused --host flag from mysqlcaller Apr 23, 2018
@HelenCampbell HelenCampbell changed the title [MODULES-6627] Removes unused --host flag from mysqlcaller (MODULES-6627) Removes unused --host flag from mysqlcaller Apr 23, 2018
@HelenCampbell HelenCampbell requested a review from hunner April 23, 2018 14:52
@hunner
Copy link
Contributor

hunner commented Apr 23, 2018

Odd since it doesn't appear to be used for anything. It was added as part of b3658f8 with this comment:

Now the options to all mysql calls can be modified from one place. This will be useful when we are converting the module to allow for databases on multiple remote servers, since we will be able to add the -h switch to all calls at once.

Perhaps it snuck in as an unfinished feature that the user was working on? Anyway, it can be added "in one place" as the comment says later if needed.

@hunner hunner merged commit 5600647 into puppetlabs:master Apr 23, 2018
hunner added a commit that referenced this pull request Apr 23, 2018
(MODULES-6627) Removes unused --host flag from mysqlcaller
@eputnam eputnam added the bugfix label May 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants